New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add relative_source_path attribute to content #2486
Conversation
This doesn't need to be a property. |
Thanks @avaris, I switched to setting I also fixed a typo in the page's attribute table in the documentation that I missed. Although, I'm having trouble figuring out if this is something others will want vs something that I want. If I'm the only one I can use the Thanks again |
For debugging purposes, I see very little benefit in this over |
Sorry for the updates, I just now noticed how bad I am at spelling |
Awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As much as I would love to see this change in sooner rather than later, there should be a unit test added. tests/test_contents.py
seems like the correct place.
Thanks @pedrohdz for the suggestion. I've added the tests. :) |
Many thanks to @bryanbrattlof for the enhancement and to @avaris, @egberts, and @pedrohdz for reviewing. 🎉 |
I wanted to see what the consensus is for adding a
relative_source_path
attribute to theContent
object.@egberts, and I in #2484 where talking about using an unpublished way to add a relative path as a comment into the generated html for
page
andarticle
for better debugging using continuous integration pipelines likegitlab-ci
.I also saw the PR (#2416) wanted the ability to generate urls to edit his content in github, but it seems like it died there.
Hope everyone's weekend it going well.