Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the category to the feed item. Fixes #2556. #2562

Closed
wants to merge 4 commits into from

Conversation

mauriciogardini
Copy link
Contributor

Adds the article category as a feed item category.

@mauriciogardini
Copy link
Contributor Author

mauriciogardini commented Apr 27, 2019

This is my first time making a pull request to Github, so correct me if I'm wrong, and sorry for any big mistakes.

The change that I made changed the xml that was generated quite dramatically. I thought that, by making the fix in my second commit that I would solve the problem, but it's bigger than it looks.

Is the best solution for me to change manually all the pelican/tests/output/custom/feeds/alexis-metaireau.atom.xml file until it is equal to what's being rendered by Travis? Or there is another way of treating a situation like this, that has many changes?

As for the other 2 errors on the build:

  • pelican.contents: ERROR: Skipping /home/travis/build/getpelican/pelican/samples/content/another_super_article-fr.rst: could not find information about 'date'
  • pelican.contents: ERROR: Skipping /home/travis/build/getpelican/pelican/samples/content/pages/jinja2_template.html: could not find information about 'title'

I see no relation of these errors with my commit. Again, is there anything that I'm missing?

@mauriciogardini mauriciogardini changed the title Adds the category to the feed item. Fix #2556. Add the category to the feed item. Fix #2556. Apr 27, 2019
@mauriciogardini mauriciogardini changed the title Add the category to the feed item. Fix #2556. Add the category to the feed item. Fixes #2556. (WIP - Fixing test fixtures) Apr 27, 2019
@avaris
Copy link
Member

avaris commented Apr 27, 2019

@mauriciogardini No, you don't do it manually. See the here for regenerating outputs.

@mauriciogardini mauriciogardini changed the title Add the category to the feed item. Fixes #2556. (WIP - Fixing test fixtures) Add the category to the feed item. Fixes #2556. Apr 28, 2019
@mauriciogardini
Copy link
Contributor Author

@mauriciogardini No, you don't do it manually. See the here for regenerating outputs.

Thanks for the help, @avaris . It was easier than expected.

Sorry for the silly questions, first time making a pull request to Github and first time making a contribution to pelican.

@justinmayer
Copy link
Member

Many thanks for the contribution, @mauriciogardini. There were some lines in the changes that looked like line-ending modifications, so I went ahead and re-generated the functional test output via 7bfc70c and manually merged into master.

This feature is included in the just-released Pelican 4.2. ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants