Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminate unsuccessfully on error as default for --fatal. Fixes #3172. #3173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Terminate unsuccessfully on error as default for --fatal. Fixes #3172. #3173

wants to merge 1 commit into from

Conversation

aknrdureegaesr
Copy link

@aknrdureegaesr aknrdureegaesr commented Aug 11, 2023 •
edited by avaris

Pull Request Checklist

Resolves: #3172

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • Updated documentation for changed code

@avaris
Copy link
Member

avaris commented Aug 12, 2023 •
edited

Why?
Please fill in the template, especially if context is provided in another issue. Commented there.

@aknrdureegaesr aknrdureegaesr mentioned this pull request Aug 14, 2023
Open
2 tasks
@aknrdureegaesr aknrdureegaesr changed the title Terminate cleanly when plugin registration fails. Fixes #3172. Terminate with error on error as default for --fatal. Fixes #3172. Aug 14, 2023
@aknrdureegaesr aknrdureegaesr changed the title Terminate with error on error as default for --fatal. Fixes #3172. Terminate unsuccessfully on error as default for --fatal. Fixes #3172. Aug 14, 2023
@offbyone
Copy link
Contributor

I agree with this change; errors should be by default a cause to terminate with a non-zero exit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin registration fails, yet Pelican continues unperturbed, resulting in broken site.
3 participants
@aknrdureegaesr @avaris @offbyone