Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve connection order in Blinker #3238

Merged
merged 1 commit into from Nov 2, 2023

Conversation

avaris
Copy link
Member

@avaris avaris commented Nov 2, 2023

Resolves: #2564

One caveat: as written in the docs change, the only way to order auto-discovered namespace plugins is to disable auto-discovery and specify order explicitly with PLUGINS setting.

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • Updated documentation for changed code

Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, @avaris. Bravo! 🎊

@justinmayer justinmayer merged commit dc1b6ab into getpelican:master Nov 2, 2023
15 checks passed
@avaris avaris deleted the ordered-blinker branch November 2, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent ordering of plugin hooks
2 participants