Fix build error for the rstudio image #10
Conversation
|
can you please rebase master? |
|
also, you can avoid having to reconcile changes on the upstream's master branch with your fork's master branch (which usually differ significantly due to squashed commits) by working on feature branches and open PRs from there. So you can first pull upstream changes to your local repo, then create a branch (from upstream's master) locally, and then push that branch to github and open a PR from there. |
This did not have any effect on my side. Am I missing something? |
r/rstudio/Dockerfile
Outdated
| # move configuration file where rstudio server will find it | ||
| COPY rsession.conf /etc/rstudio | ||
|
|
||
| # install containerit | ||
| RUN R -e "devtools::install_github(\"o2r-project/containerit\")" | ||
| RUN R -e "install.packages(\"remotes\")" \ |
There was a problem hiding this comment.
this is missing an && \ at the end
There was a problem hiding this comment.
Fixed. This should be ready to merge
sorry, I think I got confused. I thought there was a merge conflict with master but there isn't one |
The RStudio image does not have access to the
devtoolspackage to installcontaineritfrom Github. Fixed this to install and useremotesinstead