Reimplement workflow parser (drops HCL syntax)

Reimplement parser assuming no backwards-compatibility for HCL. This new implementation makes use of pykwalify and python-box to significantly simplify the parsing and validation of workflow specification, as all of this is done by these libraries instead of the Popper codebase. One breaking change is that now step attributes 'runs', 'args', and 'secrets' are now assumed to be list of strings, whereas before these could be either a string or list of strings.
getpopper · May 15, 2020 · ae7daa8 · ae7daa8
1 parent 021ba19
commit ae7daa8
Show file tree

Hide file tree

Showing 15 changed files with 146 additions and 1,601 deletions.
diff --git a/cli/popper/parser.py b/cli/popper/parser.py
diff --git a/cli/setup.py b/cli/setup.py
@@ -17,7 +17,7 @@
         "click==7.1.2",
         "docker==4.2.0",
         "GitPython==3.1.0",
-        "pyhcl==0.4.0",
+        "pykwalify==1.7.0",
         "python-box==4.2.3",
         "pyyaml==5.3.1",
         "spython==0.0.79",

diff --git a/cli/test/fixtures/a.workflow b/cli/test/fixtures/a.workflow
diff --git a/cli/test/fixtures/a.yml b/cli/test/fixtures/a.yml
diff --git a/cli/test/fixtures/b.workflow b/cli/test/fixtures/b.workflow
diff --git a/cli/test/fixtures/b.yml b/cli/test/fixtures/b.yml
diff --git a/cli/test/fixtures/missing_dependency.workflow b/cli/test/fixtures/missing_dependency.workflow
diff --git a/cli/test/fixtures/missing_dependency.yml b/cli/test/fixtures/missing_dependency.yml
diff --git a/cli/test/fixtures/ok.workflow b/cli/test/fixtures/ok.workflow
diff --git a/cli/test/fixtures/ok.yaml b/cli/test/fixtures/ok.yaml
diff --git a/cli/test/fixtures/substitutions.workflow b/cli/test/fixtures/substitutions.workflow
diff --git a/cli/test/fixtures/substitutions.yml b/cli/test/fixtures/substitutions.yml
diff --git a/cli/test/fixtures/wf_1.yml b/cli/test/fixtures/wf_1.yml
diff --git a/cli/test/test_cmd_scaffold.py b/cli/test/test_cmd_scaffold.py