feat: Added PodmanRunner to the codebase #903
Conversation
|
@ivotron can you please review this? |
|
@ivotron I've commented out the test |
There was a problem hiding this comment.
thanks @edeediong! Couple of things to hammer out and this'll be done!
src/popper/runner_host.py
Outdated
| if not self._config.dry_run: | ||
| pass | ||
| elif not self._config.skip_pull and not step.skip_pull: | ||
| log.info(f"[{step.id}] podman build {img}:{tag}") |
There was a problem hiding this comment.
this should be podman pull
There was a problem hiding this comment.
Oh that's true since I'm doing a podman pull below, thanks
src/popper/runner_host.py
Outdated
| if build: | ||
| log.info(f"[{step.id}] podman build {img}:{tag} {build_ctx_path}") | ||
| if not self._config.dry_run: | ||
| pass |
There was a problem hiding this comment.
a podman build should be executed here instead of pass.
There was a problem hiding this comment.
the above also means that we are missing a test that ensures that a Dockerfile from a public github repository is properly build as part of the execution of a workflow. Maybe we can add this to the issue we mentioned earlier, the one regarding missing tests
There was a problem hiding this comment.
I just looked at DockerRunner, I meant to put a TODO: instead of a pass. I've opened the issue and I'm gonna push changes to this effect.
No description provided.