-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(templates): add storage.template; add Makefile targets #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love more makefile targets, bring 'em! 👍
I can't really review the template though, so maybe wait on Jeremy for that?
Makefile
Outdated
$(BINDIR)/$(MIXIN)$(FILE_EXT) version | ||
|
||
test-unit: build | ||
go test ./... | ||
|
||
HAS_JSONPP := $(shell command -v jsonpp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hehe you said pp
oops! You can make a new script step in the azure-pipelines.yml file to install dependencies, like we do here and put it before the unit test step. That will make the tests pass again. |
@carolynvs Thank you! Not sure if I got the script right; will check build and tune if needed. And/or, do you think it'd be better to split build/test dependency fetching into a separate |
295ca90
to
b43b443
Compare
azure-pipelines.yml
Outdated
@@ -23,6 +23,12 @@ steps: | |||
echo '##vso[task.prependpath]$(GOROOT)/bin' | |||
displayName: 'Set up the Go workspace' | |||
|
|||
- script: | | |||
go get github.com/gobuffalo/packr/packr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with either here or in a follow-on PR making another target like make get-deps
that does all of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added get-deps
. Each target that requires it now calls it, so no real need for a separate bootstrap script here; therefore, I've removed. Let me know if I should add back in to make explicit...
e0731f5
to
f5da14d
Compare
f5da14d
to
c2d5d34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build is green, works on my machine
Open to removing/modifying Makefile additions; just found 'em helpful for development.