feat: initial CredentialSet CRD/Controller #98
Conversation
|
We'll follow up with a docs update before taking this out of draft. |
Signed-off-by: Brian DeGeeter <b.degeeter@f5.com> Co-authored-by: Steven Gettys <steven.gettys@gmail.com>
sgettys
force-pushed
the
bdegeeter/issue18
branch
from
41aa558
to
8b390e8
Compare
Signed-off-by: Steven Gettys <s.gettys@f5.com>
Codecov Report
@@ Coverage Diff @@
## main #98 +/- ##
===========================================
+ Coverage 54.47% 78.27% +23.79%
===========================================
Files 9 10 +1
Lines 995 833 -162
===========================================
+ Hits 542 652 +110
+ Misses 399 115 -284
- Partials 54 66 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Steven Gettys <s.gettys@f5.com>
…port Signed-off-by: Brian DeGeeter <b.degeeter@f5.com>
Signed-off-by: Brian DeGeeter <b.degeeter@f5.com>
Signed-off-by: Brian DeGeeter <b.degeeter@f5.com>
There was a problem hiding this comment.
One more that I couldn't comment directly on the file (kubernernetes-linux-amd64) should not be checked in. If you need the plugin binary here, let's grab it using the magefile. Or if you have already done that, this should be in the .gitignore so that it's not accidentally checked in?
|
|
||
| var _ = Describe("CredentialSet delete", func() { | ||
| Context("when an existing CredentialSet is delete", func() { | ||
| It("should run porter credentials delete", func() { |
There was a problem hiding this comment.
This test seems to be a copy of the update test above, with the extra delete action and versification. One way to make this easier to maintain going forward would be to combine them into a single test that walks through the entire lifecycle of a credential set.
Signed-off-by: Brian DeGeeter <b.degeeter@f5.com>
Signed-off-by: Steven Gettys <s.gettys@f5.com>
Signed-off-by: Brian DeGeeter <b.degeeter@f5.com>
Provides for basic CredentialSet resource supporting Kubernetes secret as a credential source