Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improper nesting of porter's trace spans #2563

Closed
carolynvs opened this issue Feb 9, 2023 · 1 comment · Fixed by #2781
Closed

Improper nesting of porter's trace spans #2563

carolynvs opened this issue Feb 9, 2023 · 1 comment · Fixed by #2781
Labels
2 - 🍕 Pizza should be eaten daily bug Oops, sorry!
Projects
Porter and Mixins

Comments

@carolynvs
Copy link
Member

When I look at Jaeger lately, I see that the spans for the main command that I'm running is being nested underneath LoadConfig which isn't right. The command's implementation function should be a sibling.

Screen Shot 2023-02-09 at 4 47 41 PM

I think this was introduced by #2541.
@carolynvs carolynvs added bug Oops, sorry! 2 - 🍕 Pizza should be eaten daily labels Feb 9, 2023
@getporterbot getporterbot added this to Inbox in Porter and Mixins Feb 9, 2023
@nitishchauhan0022
Copy link
Contributor

/assign

@nitishchauhan0022 nitishchauhan0022 mentioned this issue Jun 10, 2023
Merged
Porter and Mixins automation moved this from Inbox to Done Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 - 🍕 Pizza should be eaten daily bug Oops, sorry!
Projects
Porter and Mixins
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixing the nesting of tracing nitishchauhan0022/porter
2 participants
@carolynvs @nitishchauhan0022