fixing the nesting of tracing

[nitishchauhan0022]

What does this change

Fixes the improper nesting of traces which looks like caused by passing of the same context which is returned after logging the config traces, making the following traces as child traces of config trace.

What issue does it fix

Closes #2563

Notes for the reviewer

I have tested the tracing which is mentioned in the issue is properly nested now.

[devigned]

I believe this may cause a regression in the TraceLogger late configuration that was fixed in #2541.

Perhaps, cmd.SetContext(ctx) may need a more selective update for the TraceLogger or other stateful context items, rather than setting the entire context.

[devigned]

I believe this may cause a regression in the TraceLogger late configuration that was fixed in #2541.

Perhaps, cmd.SetContext(ctx) may need a more selective update for the TraceLogger or other stateful context items, rather than setting the entire context.

I believe the test failure output confirms this theory.

2023/06/10 12:33:34 exec: /tmp/porter1147494806/porter porter plugins install -f plugins.yaml --verbosity=info
    hello_test.go:32: 
        	Error Trace:	/home/vsts/work/1/s/tests/smoke/hello_test.go:32
        	Error:      	"read input file	{"contents": "schemaType: Plugins\nschemaVersion: 1.0.0\nplugins:\n  azure: {}"}
        	            	Downloading https://cdn.porter.sh/plugins/atom.xml to /tmp/porter204193928/atom.xml
        	            	
        	            	Downloading https://cdn.porter.sh/plugins/azure/v1.2.1/azure-linux-amd64 to /tmp/porter1147494806/plugins/azure/azure
        	            	
        	            	Downloading https://cdn.porter.sh/plugins/azure/v1.2.1/azure-linux-amd64 to /tmp/porter1147494806/plugins/azure/runtimes/azure-runtime
        	            	
        	            	installed azure plugin v1.2.1 (64fd786)
        	            	" should not contain "Downloading [https://cdn.porter.sh/plugins/atom.xml"](https://cdn.porter.sh/plugins/atom.xml%22)
        	Test:       	TestHelloBundle
        	Messages:   	Debug information should not have been printed because verbosity is set to info

[nitishchauhan0022]

Perhaps, cmd.SetContext(ctx) may need a more selective update for the TraceLogger or other stateful context items, rather than setting the entire context.

Thanks for the guidance, i will look if there are ways to do this.

[schristoff]

Hey @nitishchauhan0022 - thank you so much for your contribution. I wanted to see if you wanted any assistance getting this PR committed, or would you rather someone else try and take it over?
Let us know!

[nitishchauhan0022]

@devigned @schristoff Please take a look.

[devigned]

lgtm! Thank you for adding comments describing what is happening with the span changes.

@schristoff, what do you say?

[schristoff]

/azp run porter-integration

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[schristoff]

Thank you so much for this contribution!
Don't forget to make another PR and add your name to our contributors file!
🎉