Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(*): add a few missing parameters config items #1054

Merged
merged 2 commits into from
May 22, 2020

Conversation

vdice
Copy link
Member

@vdice vdice commented May 21, 2020

What does this change

  • Adds documentation around a few additional configuration options for parameters

What issue does it fix

Closes #934

Notes for the reviewer

Checklist

  • Unit Tests - N/A
  • Documentation
  • Schema (porter.yaml) - N/A

Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but one link wasn't working

docs/content/wiring.md Outdated Show resolved Hide resolved
Co-authored-by: Carolyn Van Slyck <carolyn.vanslyck@microsoft.com>
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:excellent:

@carolynvs carolynvs merged commit b22ec2b into getporter:master May 22, 2020
@vdice vdice deleted the docs/params branch May 22, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc missing for parameter definition
2 participants