Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(distribute-bundles.md): minor amendments #1059

Merged
merged 1 commit into from
May 28, 2020

Conversation

vdice
Copy link
Member

@vdice vdice commented May 28, 2020

What does this change

  • Amends a few typos and/or areas of text

What issue does it fix

N/A, discovered after revisiting docs

Notes for the reviewer

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

Signed-off-by: Vaughn Dice <vadice@microsoft.com>
@@ -78,7 +78,7 @@ executing porter install configuration from /cnab/app/porter.yaml
Install Hello World App
```

The later example ensures immutability for your bundle. After you've initially run `porter publish`, your tagged reference, such as `getporter/kubernetes:v0.1.0` can be updated with subsequent `porter publish` commands. However, the digested version `getporter/kubernetes@sha256:10a41e6d5af73f2cebe4bf6d368bdf5ccc39e641117051d30f88cf0c69e4e456` will not change. If you'd like to publish different version of the bundle, you will need to update minimally the `tag` attribute and optionally the `invocationImage` attribute, before running `porter publish` again. (Porter will detect the manifest change and automatically run a new bundle and invocation image build prior to publishing.)
The latter example ensures immutability for your bundle. After you've initially run `porter publish`, your tagged reference, such as `getporter/kubernetes:v0.1.0` can be updated with subsequent `porter publish` commands. However, the digested version `getporter/kubernetes@sha256:10a41e6d5af73f2cebe4bf6d368bdf5ccc39e641117051d30f88cf0c69e4e456` will not change. If you'd like to publish different version of the bundle, you will need to update minimally the `tag` attribute and optionally the `invocationImage` attribute, before running `porter publish` again. (Porter will detect the manifest change and automatically run a new bundle and invocation image build prior to publishing.)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change here should be s/later/latter

Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whale say we all, amendment passed!

@carolynvs carolynvs added this to In Progress in Porter and Mixins [OLD] via automation May 28, 2020
@carolynvs carolynvs merged commit ae198a9 into getporter:master May 28, 2020
Porter and Mixins [OLD] automation moved this from In Progress to Done May 28, 2020
@vdice vdice deleted the docs/distribute-bundles branch May 28, 2020 21:23
@vdice vdice removed this from Done in Porter and Mixins [OLD] Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants