Fix unit test ValidateFeedURL and ValidateURL
#1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
requested changes
Jul 24, 2020
pkg/pkgmgmt/install_test.go
Outdated
| @@ -75,7 +77,8 @@ func TestInstallOptions_ValidateFeedURL(t *testing.T) { | |||
| FeedURL: "$://example.com", | |||
| } | |||
| err := opts.validateFeedURL() | |||
| require.EqualError(t, err, "invalid --feed-url $://example.com: parse $://example.com: first path segment in URL cannot contain colon") | |||
| assert.True(t, strings.Contains(err.Error(), fmt.Sprintf("invalid --feed-url %s", opts.FeedURL))) | |||
There was a problem hiding this comment.
I wanted to let you know about another testify function assert.Contains that can simplify your checks and improve the error message when the check fails:
Suggested change
| assert.True(t, strings.Contains(err.Error(), fmt.Sprintf("invalid --feed-url %s", opts.FeedURL))) | |
| assert.Contains(t, err.Error(), fmt.Sprintf("invalid --feed-url %s", opts.FeedURL)) |
carolynvs
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Fix a failing unit test when running porter with go 1.14
Checklist
If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇♀️