Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): add installation delete options/flags to relevant commands #1189

Merged
merged 11 commits into from Aug 19, 2020
Merged

feat(*): add installation delete options/flags to relevant commands #1189

merged 11 commits into from Aug 19, 2020

Commits on Aug 18, 2020

  1. feat(*): add installation delete options/flags to relevant commands 

    Signed-off-by: Vaughn Dice <vadice@microsoft.com>
    @vdice
    vdice committed Aug 18, 2020
    Copy the full SHA
    30e8fb1 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    @vdice @carolynvs
    vdice and carolynvs committed Aug 18, 2020
    Copy the full SHA
    1e0c21e View commit details
    Browse the repository at this point in the history

  3. incorporate add'l review feedback 

    Signed-off-by: Vaughn Dice <vadice@microsoft.com>
    @vdice
    vdice committed Aug 18, 2020
    Copy the full SHA
    222b196 View commit details
    Browse the repository at this point in the history

  4. add'l review feedback 

    Signed-off-by: Vaughn Dice <vadice@microsoft.com>
    @vdice
    vdice committed Aug 18, 2020
    Copy the full SHA
    ba43169 View commit details
    Browse the repository at this point in the history

  5. refactor the parent/dep uninstall scenarios 

    Signed-off-by: Vaughn Dice <vadice@microsoft.com>
    @vdice
    vdice committed Aug 18, 2020
    Copy the full SHA
    b77e8c2 View commit details
    Browse the repository at this point in the history

  6. update dependencies_test.go 

    Signed-off-by: Vaughn Dice <vadice@microsoft.com>
    @vdice
    vdice committed Aug 18, 2020
    Copy the full SHA
    6c64917 View commit details
    Browse the repository at this point in the history

  7. use BundleAction interface to enable action-specific options when exe… 

    …cuting dependencies

Signed-off-by: Vaughn Dice <vadice@microsoft.com>
    @vdice
    vdice committed Aug 18, 2020
    Copy the full SHA
    4b2b647 View commit details
    Browse the repository at this point in the history

  8. ref(tests/dependencies_test.go): set mysql dep namespace param as well 

    Signed-off-by: Vaughn Dice <vadice@microsoft.com>
    @vdice
    vdice committed Aug 18, 2020
    Copy the full SHA
    353dfd5 View commit details
    Browse the repository at this point in the history

  9. fix cmd example spacing 

    Signed-off-by: Vaughn Dice <vadice@microsoft.com>
    @vdice
    vdice committed Aug 18, 2020
    Copy the full SHA
    7f5b60c View commit details
    Browse the repository at this point in the history

  10. add comments around uninstallOpts when empty 

    Signed-off-by: Vaughn Dice <vadice@microsoft.com>
    @vdice
    vdice committed Aug 18, 2020
    Copy the full SHA
    27f00be View commit details
    Browse the repository at this point in the history

  11. remove ToActionArgs from BundleAction interface 

    Signed-off-by: Vaughn Dice <vadice@microsoft.com>
    @vdice
    vdice committed Aug 18, 2020
    Copy the full SHA
    97a31c4 View commit details
    Browse the repository at this point in the history