Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(build.go): defer cnab dir/porter.yaml COPY statements #119

Merged
merged 1 commit into from Jan 22, 2019

Conversation

vdice
Copy link
Member

@vdice vdice commented Jan 18, 2019

Perhaps there was a design decision on placing these first -- but if not, I find when I develop a bundle, I'm usually iterating/changing files in the cnab dir and/or the porter.yaml file, so thought they'd come last in the generated Dockerfile to avoid re-running mixin dependency steps. Thoughts?

@ghost ghost assigned vdice Jan 18, 2019
@ghost ghost added the review label Jan 18, 2019
Copy link
Contributor

@jeremyrickard jeremyrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good change to me. LGTM pending CI.

@jeremyrickard jeremyrickard merged commit b2632de into getporter:master Jan 22, 2019
@vdice vdice deleted the ref/defer-cp branch January 22, 2019 17:19
@carolynvs carolynvs added released and removed review labels Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants