ref(*): misc code, comment, docs updates around claims #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
carolynvs
approved these changes
Aug 10, 2020
| @@ -31,7 +31,7 @@ func (so *ShowOptions) Validate(args []string, cxt *context.Context) error { | |||
| return so.ParseFormat() | |||
| } | |||
|
|
|||
| // ShowInstallation shows a bundle, or more properly a bundle claim, along with any | |||
| // ShowInstallation shows a bundle installation, along with any | |||
There was a problem hiding this comment.
Thanks these were exactly the type of inaccurate comments that were causing confusion. 👍
| @@ -34,9 +34,9 @@ func NewPorterRuntime(cxt *context.Context, mixins pkgmgmt.PackageManager) *Port | |||
| func (r *PorterRuntime) Execute(rm *RuntimeManifest) error { | |||
| r.RuntimeManifest = rm | |||
|
|
|||
| claimName := os.Getenv(config.EnvClaimName) | |||
| installationName := os.Getenv(config.EnvInstallationName) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
What issue does it fix
Closes #1105
Notes for the reviewer
Checklist
If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇♀️