Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-manifest): defer to bundle-level output def sensitivity #1206

Merged

Conversation

vdice
Copy link
Member

@vdice vdice commented Aug 11, 2020

What does this change

  • Updates logic around masking output values. We still regard step outputs as sensitive by default, but this updates step outputs that are also bundle-level outputs to inherit the bundle-level output setting. (Note that bundle-level outputs are not sensitive by default.)

What issue does it fix

N/A

Notes for the reviewer

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

@carolynvs
Copy link
Member

One of my other PRs has a big impact on this one because OutputDefinitions is now a map which makes it much easier to get at what's defined in the manifest. It just landed in main, so I'll hold off on reviewing until you've had a chance to rebase. Sorry about that but I think it will make this PR easier!

@carolynvs carolynvs self-assigned this Aug 21, 2020
@carolynvs carolynvs added this to In Progress in Porter and Mixins [OLD] via automation Aug 21, 2020
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
@vdice vdice force-pushed the fix/defer-to-bundle-level-output-sensitivity branch from 6bdaff5 to 6dc91ab Compare August 25, 2020 16:26
@vdice
Copy link
Member Author

vdice commented Aug 25, 2020

Thanks @carolynvs ; indeed, your recent updates have made this change set much simpler! Rebased and ready for another look when convenient.

Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is much cleaner with the rebase and edits. 💯 LGTM!

@carolynvs carolynvs merged commit 40034a8 into getporter:main Aug 25, 2020
Porter and Mixins [OLD] automation moved this from In Progress to Done Aug 25, 2020
@vdice vdice deleted the fix/defer-to-bundle-level-output-sensitivity branch August 25, 2020 18:43
@vdice vdice removed this from Done in Porter and Mixins [OLD] Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants