Added Client Version for Kubernetes Mixin #1221
Conversation
donmstewart
requested review from
carolynvs,
jeremyrickard and
vdice
as code owners
|
|
There was a problem hiding this comment.
Thank you for the PR @donmstewart. Code looks great!
My only request would be to add unit test coverage for this feature. (A recent example of prior art can be found in https://github.com/deislabs/porter-docker/pull/25/files#diff-702f25c50cf68ba27df0514c69a8012a)
|
Added tests look great @donmstewart - thank you. One quibble: I don't think https://github.com/deislabs/porter/issues/1136 should be listed as being closed by this PR, as it appears to relate to runtime version matching as opposed to build-time version fetching, which is what this PR accomplishes. |
|
I don't think thats a quibble I think thats a perfectly valid point. Can we mark this just for #1135 for now and I'll do #1136 as a new PR after this is in? |
Changes to the Kubernetes Mixin in order the user can pass in the version of kubectl to install which then downloads kubectl in the build action.
What issue does it fix
Closes #1135