Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag dep output wiring parameters as internal #1222

Merged
merged 1 commit into from Aug 21, 2020
Merged

Flag dep output wiring parameters as internal #1222

merged 1 commit into from Aug 21, 2020

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented Aug 21, 2020 •
edited

What does this change

  • Flag dependency output wiring parameters as internal
  • Fix unit test to sort properly so it passes all the time

What issue does it fix

Follow-up from #1202 and #1193 landing and becoming quantum entangled.

Notes for the reviewer

NA

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

@carolynvs
Flag dep output wiring parameters as internal
f393e2a 
* Fix unit test to sort properly so it passes all the time
@carolynvs carolynvs added this to In Progress in Porter and Mixins [OLD] via automation Aug 21, 2020
@carolynvs carolynvs merged commit 61fbea6 into getporter:main Aug 21, 2020
Porter and Mixins [OLD] automation moved this from In Progress to Done Aug 21, 2020
@carolynvs carolynvs deleted the fix-depoutputs branch August 21, 2020 21:16
@vdice vdice removed this from Done in Porter and Mixins [OLD] Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdice vdice vdice approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carolynvs @vdice