Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve authory byline on blog posts #1304

Merged
merged 3 commits into from Sep 28, 2020
Merged

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented Sep 28, 2020

What does this change

  • Display optional author image
  • Display handle on separate line
  • Update carolyn's posts to link to her website
  • Fix makefile to build future dated posts

https://deploy-preview-1304--porter.netlify.app/blog/docker-mixin-blog-post/

What issue does it fix

Make pretty blog posts and give authors better credit. Hopefully we can encourage external contributors and users to post.

Notes for the reviewer

N/A

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

* Display optional author image
* Display handle on separate line
* Update carolyn's posts to link to her website
* Fix makefile to build future dated posts

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs carolynvs marked this pull request as ready for review September 28, 2020 17:07
@carolynvs carolynvs added this to In Progress in Porter and Mixins via automation Sep 28, 2020
@carolynvs
Copy link
Member Author

I'm annoyed by the tags and wish I could display them on the left and the author on the right but I timeboxed it and went over. If someone cares and wants to throw time at that (it's not important enough for me to keep trying), have at it. 😭

@carolynvs carolynvs mentioned this pull request Sep 28, 2020
3 tasks
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carolynvs carolynvs merged commit 5730aed into getporter:main Sep 28, 2020
Porter and Mixins automation moved this from In Progress to Done Sep 28, 2020
@carolynvs carolynvs deleted the author-image branch September 28, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants