Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃帹 Align date to left and put under title in article/blog page #1315

Merged
merged 2 commits into from Oct 7, 2020

Conversation

dev-drprasad
Copy link
Contributor

@dev-drprasad dev-drprasad commented Oct 6, 2020

What does this change

Align date to left and put under title in article/blog page

Before PR:
Screenshot 2020-10-06 at 3 37 58 PM

After PR:
Screenshot 2020-10-06 at 3 38 08 PM

What issue does it fix

Closes #1302

Notes for the reviewer

N/A

Checklist

  • Unit Tests - N/A
  • Documentation - N/A
  • Schema (porter.yaml) - N/A

Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better, thanks!

@carolynvs
Copy link
Member

Oops, the DCO check is failing. You can fix it by running git commit --amend -s then force pushing back up to your branch.

@carolynvs carolynvs self-assigned this Oct 6, 2020
@carolynvs carolynvs added this to In Progress in Porter and Mixins via automation Oct 6, 2020
Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for fixing. Don't forget to do the DCO process :D

@dev-drprasad dev-drprasad force-pushed the 1302-date-to-left branch 2 times, most recently from 0f88e24 to f472f8f Compare October 7, 2020 11:40
Signed-off-by: REDDY PRASAD <dev.drprasad@aim.com>
Signed-off-by: REDDY PRASAD <dev.drprasad@aim.com>
@dev-drprasad
Copy link
Contributor Author

All checks have passed

@carolynvs carolynvs merged commit 2fcaeb4 into getporter:main Oct 7, 2020
Porter and Mixins automation moved this from In Progress to Done Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

blog design: dangling date in single blog post view
3 participants