Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fix md syntax in CONTRIBUTING.md #1316

Merged
merged 1 commit into from Oct 7, 2020

Conversation

dev-drprasad
Copy link
Contributor

What does this change

Just md syntax fix

What issue does it fix

N/A

Notes for the reviewer

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

@@ -344,7 +344,7 @@ a new blog post and then preview it:
1. [Preview](#preview-documentation) the website and click "Blog" at the top right to find your blog post.

1. When you create a pull request, look at the checks run by the pull request,
and click "Details" on the *netlify/porter/deploy-preview** one to see a live
and click "Details" on the **netlify/porter/deploy-preview** one to see a live
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still unclear for me whether it was supposed to be italic or bold :)

@dev-drprasad
Copy link
Contributor Author

https://twitter.com/rafrasenberg/status/1311627619973107715

This is totally unnecessary comment and I don't why I am posting here

Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 馃挅

@carolynvs
Copy link
Member

Oops, the DCO check is failing. You can fix it by running git commit --amend -s then force pushing back up to your branch.

@carolynvs carolynvs self-assigned this Oct 6, 2020
@carolynvs carolynvs added this to In Progress in Porter and Mixins via automation Oct 6, 2020
@dev-drprasad
Copy link
Contributor Author

@carolynvs re-committed

Signed-off-by: REDDY PRASAD <dev.drprasad@aim.com>
@carolynvs carolynvs merged commit cf14b9a into getporter:main Oct 7, 2020
Porter and Mixins automation moved this from In Progress to Done Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants