Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pkg/printer): add yaml and raw printers #133

Merged
merged 4 commits into from Feb 8, 2019

Conversation

vdice
Copy link
Member

@vdice vdice commented Feb 1, 2019

Ref: getporter/helm2-mixin#12

Adds yaml and raw printers to the printer pkg.

@ghost ghost assigned vdice Feb 1, 2019
@ghost ghost added the review label Feb 1, 2019
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yaml printer is ready to ship after we either split it out or hash out here my questions on the raw printer.

"io"
)

// PrintRaw is a printer that prints the provided value as is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So raw is really a dump of the go structure? Let me know if I don't have that right.

What's the use case for this format? json and yaml I see people using that in scripts. If they are chaining the output of this new raw format into a Go program I want to make sure that maybe there isn't an easier way (like making it so that they can use our libraries and functions directly from their code). Or at least making sure that it's a consumable format (e.g. maybe we should be using %#v instead).

Also once we have hammered out the use case, let's pick a name that describes the format more clearly, e.g. "go" or something along those lines.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to change to FormatPlaintext per getporter/helm2-mixin#12 (comment)

pkg/printer/plaintext.go Outdated Show resolved Hide resolved
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick! Merge before it's 5pm somewhere. 💨

@carolynvs carolynvs merged commit 4d5fbb8 into getporter:master Feb 8, 2019
@ghost ghost removed the review label Feb 8, 2019
@vdice vdice deleted the feat/printer-yaml branch February 8, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants