Fix the service fabric example bundle #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump the base image and update the commands to match the updated instructions. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
|
Merge like the build is broken! 💨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Bump the base image and update the commands to match the updated instructions.
What issue does it fix
Broken builds
Notes for the reviewer
We should review our examples and consider moving them into a separate repo and build, triggered when new releases of porter are created. Some of the examples when they fail have nothing to do with if porter is working or not, and it's are slow build build them all.
Checklist