Update exec-outputs example for the k8s driver #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a bundle is executed on kubernetes, files are injected into the bundle using volume mounts. The mount point cannot be used in a move or remove operation. So while this bundle worked okay on Docker (because the docker driver injects files into the bundle using cp), the bundle fails with "device or resource busy" on the kubernetes driver. Long term this is something that Porter can help workaround, but for now this fixes the bundle so that it doesn't try to move a file that was injected as a parameter or credential. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
vdice
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
When a bundle is executed on kubernetes, files are injected into the bundle using volume mounts. The mount point cannot be used in a move or remove operation. So while this bundle worked okay on Docker (because the docker driver injects files into the bundle using cp), the bundle fails with "device or resource busy" on the kubernetes driver.
Long term this is something that Porter can help workaround, but for now this fixes the bundle so that it doesn't try to move a file that was injected as a parameter or credential.
What issue does it fix
Gets this example to work with the Porter Operator.
Notes for the reviewer
N/A
Checklist