Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document custom section in porter.yaml #1481

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

carolynvs
Copy link
Member

What does this change

  • Update porter schema so that intellisense works correctly in VS Code.
  • Document the expected format, a map of strings, and how to read the values when the bundle is executing.

What issue does it fix

This was reported by Prasad @ Microsoft that there wasn't documentation or intellisense support.

Notes for the reviewer

NA

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

* Update porter schema so that intellisense works correctly in VS Code.
* Document the expected format, a map of strings, and how to read the
values when the bundle is executing.

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs
Copy link
Member Author

I always forget that we have a test that compares against the golden schema. 🤦‍♀️

@carolynvs carolynvs merged commit 37bd344 into getporter:main Mar 4, 2021
@carolynvs carolynvs deleted the custom-schema branch March 4, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants