Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Porter's relationship with CNAB #1485

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented Mar 9, 2021

What does this change

  • What do we support
  • Our plans for the spec
  • How to use different CNAB tools together

https://deploy-preview-1485--porter.netlify.app/cnab/
https://deploy-preview-1485--porter.netlify.app/faq/#does-porter-fully-implement-the-cnab-specification
https://deploy-preview-1485--porter.netlify.app/faq/#can-i-use-porter-bundles-with-other-cnab-tools

What issue does it fix

This takes an answer from Slack and puts it into our official docs.

Notes for the reviewer

N/A

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

@carolynvs carolynvs requested a review from iennae March 9, 2021 18:30
@carolynvs carolynvs added this to In Progress in Porter and Mixins via automation Mar 9, 2021
* What do we support
* Our plans for the spec
* How to use different CNAB tools together
* Underline links on homepage

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions; LGTM!


* [CNAB Dependencies] ✅ - Covers bundles depending upon other bundles, for example
WordPress depending upon a MySQL bundle. The spec is still in DRAFT and has
major changes planned. Porter suports the DRAFT and serves as the reference
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
major changes planned. Porter suports the DRAFT and serves as the reference
major changes planned. Porter supports the DRAFT and serves as the reference

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs carolynvs merged commit 7192f1a into getporter:main Mar 10, 2021
Porter and Mixins automation moved this from In Progress to Done Mar 10, 2021
@carolynvs carolynvs deleted the cnab-compliance branch March 10, 2021 18:17
joshuabezaleel pushed a commit to joshuabezaleel/porter that referenced this pull request Mar 14, 2021
* Document Porter's relationship with CNAB

* What do we support
* Our plans for the spec
* How to use different CNAB tools together
* Underline links on homepage

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>

* Fix typo

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants