Allow overriding home dir and download url during install #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing, let the user override with PORTER_HOME and PORTER_MIRROR the location where porter should be installed, or the location from which it should be downloaded. I have updated the porter CLI to understand the new configuration value PORTER_MIRROR, which and also be specified as a flag or config file setting. This lets us test out alternate download infra from end-to-end, and also allows a user to set up a mirror of Porter's assets. I am also getting rid of the troubleshooting I had added for Azure's storage and CDN now that we aren't using it anymore (e.g. dynamically generated PORTER_TRACE user agents). Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
|
/azp run porter-install-check |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
vdice
approved these changes
Apr 13, 2021
docs/content/install.md
Outdated
| @@ -13,9 +13,11 @@ We have a few release types available for you to use: | |||
| * [Older Version](#older-version) | |||
|
|
|||
| You can also install and manage [mixins](#mixins) and [plugins](#plugins) using | |||
| porter, and use the [Porter VS Code Extension][vscode-ext] for help authoring | |||
| porter, and use the [Porter VS Code Extension][vscode-ext] for help author | |||
There was a problem hiding this comment.
Perhaps change back to authoring -- or '.. to help author bundles' ?
docs/content/install.md
Outdated
|
|
||
| # Install Script Parameters | ||
|
|
||
| The installation scripts provide the following parameters. Paramters can be specified with environment variables for the macOS and Linux scripts, and on Windows they are named parameters in the script. |
There was a problem hiding this comment.
Suggested change
| The installation scripts provide the following parameters. Paramters can be specified with environment variables for the macOS and Linux scripts, and on Windows they are named parameters in the script. | |
| The installation scripts provide the following parameters. Parameters can be specified with environment variables for the macOS and Linux scripts, and on Windows they are named parameters in the script. |
There was a problem hiding this comment.
I fixed a couple places with that same typo. I really have trouble with typing that word! 😊
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
When installing, let the user override with PORTER_HOME and PORTER_MIRROR the location where porter should be installed, or the location from which it should be downloaded.
I have updated the porter CLI to understand the new configuration value PORTER_MIRROR, which and also be specified as a flag or config file setting.
This lets us test out alternate download infra from end-to-end, and also allows a user to set up a mirror of Porter's assets.
I am also getting rid of the troubleshooting I had added for Azure's storage and CDN now that we aren't using it anymore (e.g. dynamically generated PORTER_TRACE user agents).
What issue does it fix
Fixes https://groups.io/g/porter/message/30
Notes for the reviewer
N/A
Checklist