Do not copy extra junk when installing dev build of porter #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The install target is a bit lazy and copies everything in certain directories. This results in files that do not need to be installed copied into PORTER_HOME. For example, the release directories (dev, latest, tagged) for the exec mixin. The extra binaries are a problem because it seriously bloats invocation images built on a dev machine. This moves the logic to our magefile, and is more explicit about what we want to copy. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
When running porter from the bin directory, PORTER_HOME must be set. Otherwise Porter will use ~/.porter Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
changed the title
vdice
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
The install target is a bit lazy and copies everything in certain directories. This results in files that do not need to be installed
copied into PORTER_HOME. For example, the release directories (dev, latest, tagged) for the exec mixin.
The extra binaries are a problem because it seriously bloats invocation images built on a dev machine.
This moves the logic to our magefile, and is more explicit about what we want to copy.
What issue does it fix
My chonky invocation images
Notes for the reviewer
I'm considering a follow-up that makes porter more selective when copying files into the invocation image, e.g. only the runtimes and not blanket copying the entire mixin directory for each mixin.
Checklist