Count only the parameters in the parameter set #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: div_bhasin <divbest99@gmail.com>
divbhasin
requested review from
carolynvs,
jeremyrickard and
vdice
as code owners
divbhasin
commented
May 29, 2021
| @@ -25,8 +25,9 @@ credentials: | |||
| - uninstall | |||
|
|
|||
| dependencies: | |||
| - name: mysql | |||
| reference: "getporter/azure-mysql:5.7" | |||
| requires: | |||
There was a problem hiding this comment.
This change is unrelated to the PR. Without it, the "TestManifestConverter_generatedMaintainers" was failing.
Signed-off-by: div_bhasin <divbest99@gmail.com>
carolynvs
approved these changes
Jun 2, 2021
|
Sorry I forgot to respond to your question about "parameter(s)". Yes, if you would like to submit a PR to change it to "parameter(s)" that would be great. Also congrats on your first pull request to Porter! 🎉 We like to thank our contributors by having them add their name to our contributors.md file at the root of the repository. You are welcome to add your name to the file anytime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
When using
porter parameters generate..., we see only the number of parameters in the parameter set being generated now. Look at the "Porter Command and Output" screenshot in #1600 to see what was wrong before. For the same command, we now get:What issue does it fix
Closes #1600
Notes for the reviewer
For the "1 parameters declared for bundle..." in the above screenshot, should I change the "parameters" to "parameter(s)" to account for the above case where we might only have 1 parameter in the parameter set? Alternatively, we could also do a switch/if statement to be more precise.
Checklist