Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhances how we're handling sourcing #162

Merged
merged 2 commits into from
Feb 13, 2019
Merged

Enhances how we're handling sourcing #162

merged 2 commits into from
Feb 13, 2019

Commits on Feb 13, 2019

  1. Enhances how we're handling slice processing for param/credential/out… 

    …put sourcing

This PR updates how we handle slice elements for doing parameter/credential/ouput sourcing.
We probably should think about revisitng the entire process for this in the future.

In summary, we are using reflectwalk to handle walking the manifest. This involves handling a couple
call backs, notably "SliceElement" and "MapElement". The Slice Element assumed that it would see something
of the form source: <x.y.z> as a string. In reality, if that's not wrapped in quote, Go and YAML see that
as a Map, but the map callback doesn't get called to handle that. This was resulting in the block not getting
rewritten and the exec mixin was exploding (probably any would have). This PR updates the logic of the slice elem
processing to check and see if it's a map and handle it in a similar manner to a top level map entry in the yaml.

Closes: getporter#158
    @jeremyrickard
    jeremyrickard committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    0597f8e View commit details
    Browse the repository at this point in the history

  2. Cleaned up a case statement and fixed an error

    @jeremyrickard
    jeremyrickard committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    1c8a188 View commit details
    Browse the repository at this point in the history