Support stringArray cobra flag type #1998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for mapping the cobra flag type stringArray. This is prep-work for getporter#1862 Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
4 tasks
VinozzZ
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Add support for mapping the cobra flag type stringArray. Specifically we should be using stringArray when we do not want cobra to treat flag values with a comma as a comma separated list.
What issue does it fix
This is prep-work for #1862 and #1999
Notes for the reviewer
N/A
Checklist
Reviewer Checklist