Inject porter-debug param into all bundles #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will let us handoff a --debug flag from porter install into the bundle without the user having to manually specify the parameter. So the user can run `porter install --debug` and porter will handle automatically turning on the porter-debug parameter when it executes the bundle, and then `porter run` will pick it up and bind its `--debug` flag to that automatically. This is just the first step of defining the parameter for all porter built bundles.
ghost
assigned 
vdice
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let us handoff a --debug flag from porter install into the bundle without the user having to manually specify the parameter.
So the user can run
porter install --debugand porter will handle automatically turning on the porter-debug parameter when it executes the bundle, and thenporter runwill pick it up and bind its--debugflag to that automatically.This is just the first step of defining the parameter for all porter built bundles.