Document why we use require in long tests #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is follow up to getporter#2641 (comment) which documents why we use require in integration/smoke tests instead of assert. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
4 tasks
arschles
reviewed
Mar 23, 2023
Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com> Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
|
Thanks for the suggested text, @arschles! 🙇♀️ |
arschles
approved these changes
Mar 23, 2023
bdegeeter
pushed a commit
to bdegeeter/porter
that referenced
this pull request
May 11, 2023
* Document why we use require in long tests This is follow up to getporter#2641 (comment) which documents why we use require in integration/smoke tests instead of assert. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com> * Apply suggestions from code review Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com> Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com> --------- Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com> Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow up to #2641 (comment) which documents why we use require in integration/smoke tests instead of assert.