Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test-terraform.sh): pass in param on uninstall #276

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

vdice
Copy link
Member

@vdice vdice commented Apr 16, 2019

Closes getporter/terraform-mixin#8

Note: full fix included the following changes that slipped into a previous PR: https://github.com/deislabs/porter/pull/275/files#diff-6179e983ed8dc381b341cb64ef9c5519

@ghost ghost assigned vdice Apr 16, 2019
@ghost ghost added the review label Apr 16, 2019
@vdice vdice requested a review from carolynvs April 16, 2019 21:01
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passes, LGTM

@carolynvs
Copy link
Member

Manually merging, I'm making the azure devops build go away as we speak for PR builds.

@carolynvs carolynvs merged commit 3ea4cad into getporter:master Apr 16, 2019
@ghost ghost removed the review label Apr 16, 2019
@vdice vdice deleted the fix/terraform-test branch April 16, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should unininstall pass parameters?
2 participants