Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker to look up current context vs hardcoding to "default" #2956

Merged
merged 2 commits into from Dec 14, 2023

Conversation

rayterrill
Copy link
Contributor

What does this change

Use docker to look up current context vs hardcoding to "default"

For example if it introduces a new command or modifies a commands output, give an example of you running the command and showing real output here.

What issue does it fix

Closes #2901

If there is not an existing issue, please make sure we have context on why this change is needed. See our Contributing Guide for examples of when an existing issue isn't necessary.

Notes for the reviewer

Put any questions or notes for the reviewer here.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@schristoff
Copy link
Contributor

Hey!

Thank you so much for this - if you could please sign the DCO we should be able to get this merged :)

Signed-off-by: Ray Terrill <rayterrill@users.noreply.github.com>
Signed-off-by: Ray Terrill <rayterrill@users.noreply.github.com>
@rayterrill
Copy link
Contributor Author

@schristoff done!

@schristoff
Copy link
Contributor

/azp run porter-integration

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@schristoff schristoff merged commit 8b74d90 into getporter:main Dec 14, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bug): context not set for using docker-desktop
2 participants