Add dockerfile template to manifest #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
When a dockerfile template is specified in the manifest, instead of using the default Dockerfile template (which uses debian:stretch for the FROM), the user can supply their own template Dockerfile that they commit alongside the porter.yaml file. During porter build, we use that as the template, and appending lines to it. It is the responsibility of the user to ensure that it is a suitable image. For example, FROM scratch wouldn't work well because it doesn't provide root ssl certificates, but FROM ubuntu would be just fine.
These are all function names on a struct named template, they don't all need to end in *Template as well
carolynvs
force-pushed
the
custom-dockerfile
branch
from
48e3dfe
to
558dd46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41
I went with adding Dockerfile template field to the manifest. This way people have the flexibility to use whatever file naming they prefer and we don't run into issues when we write out the final Dockerfile. Originally I had suggested looking for an existing file named Dockerfile, which wouldn't work after
porter buildwas run the first time (without changing how porter build works).