Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate cnab directory during porter build #364

Merged
merged 4 commits into from May 30, 2019

Conversation

carolynvs
Copy link
Member

  • cnab/ is generated during build now
  • we copy all files in the directory into /cnab/app unless they are using a dockerfile template
  • Generate template files during porter create to help guide them
    • README.md
    • .gitignore
    • .dockerignore
    • Dockerfile.tmpl
  • Update our tests to run in /tmp/porter/* so that we aren't copying the entire porter source code into the invocation images 馃榾

@carolynvs carolynvs requested a review from vdice May 29, 2019 18:27
@carolynvs carolynvs marked this pull request as ready for review May 29, 2019 18:43
* cnab/ is generated during build now
* we copy all files in the directory into /cnab/app unless they are
using a dockerfile template
* Generate template files during porter create to help guide them
  * README.md
  * .gitignore
  * .dockerignore
  * Dockerfile.tmpl
Explain how the current directory is copied automatically when a Dockerfile
template is not used. Otherwise it is up to you to manually copy files.
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/content/build-image.md Outdated Show resolved Hide resolved
pkg/porter/templates/create/README.md Outdated Show resolved Hide resolved
pkg/porter/create_test.go Show resolved Hide resolved
@carolynvs carolynvs merged commit 05092cc into getporter:master May 30, 2019
@carolynvs carolynvs deleted the generated-files branch May 30, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants