Write bundle.json to cnab/ #373
Conversation
|
This LGTM. I don't see the publish update in here, should I take care of that in the PR I'm working on right now? |
|
I don't think anything explicit needs to happen for publish. In Let me know if there's another spot! |
There was a problem hiding this comment.
I don't think anything explicit needs to happen for publish. In
Validateit's only looking for porter.yaml. InPublishit is callingp.buildBuildlewhich I fixed in this PR to output to cnab/.Let me know if there's another spot!
Oh you're right. I forgot what code I wrote yesterday :)
| @@ -122,42 +120,29 @@ func (o *sharedOptions) validateBundlePath() error { | |||
|
|
|||
| // defaultBundleFile defaults the bundle file to the bundle in the current directory | |||
| // when none is set. | |||
| func (o *sharedOptions) defaultBundleFile() error { | |||
| func (o *sharedOptions) defaultBundleFile(cxt *context.Context) error { | |||
| if o.File != "" { | |||
There was a problem hiding this comment.
should we actually validate that this file exists? i wondered that before when I was looking at this.
There was a problem hiding this comment.
In this PR I was just preserving the original logic. I'm not sure why I didn't validate if the file exists before. Possibly because I didn't have the context? We could do it now pretty easily.
As part of #320, during
porter buildbundle.json is written to cnab/ now, and the cnab actions and publish look for it in cnab/.