Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Makefile): fix bundle validation by fetching/supplying definitions schema #581

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

vdice
Copy link
Member

@vdice vdice commented Sep 4, 2019

Now that the bundle schema references the new definitions.schema.json, we need to fetch this referenced schema and supply it to the ajv cli for validation. (This manual step is needed until cnabio/cnab.io#15 is closed.)

@carolynvs
Copy link
Member

This looks good but I was hoping to see publishexamplebundles pass on the PR. It doesn't seem to have run though?

@vdice
Copy link
Member Author

vdice commented Sep 4, 2019

@carolynvs previously/currently we only publish bundles on merges to master. Perhaps the thinking was we might not want to publish them from some/all PRs. We can update the logic to run that task on PRs, though. WDYT?

(We do still run validation on the bundles on PRs; it's the validate check, e.g. https://github.com/deislabs/porter/pull/581/checks?check_run_id=212309404 / https://brigadecore.github.io/kashti/jobs/porter-validate-01dkywajb6e3pa10eyk7jg7fsz)

@carolynvs
Copy link
Member

Thanks! I was looking for validate. 👍

@carolynvs carolynvs merged commit 05f8c4e into getporter:master Sep 4, 2019
@vdice vdice deleted the fix/validation branch September 4, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants