Ignore porter.yaml when --tag is specified #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
force-pushed
the
install-tag-no-build
branch
from
9b8fb9b
to
a15a41a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more general fix for #585. When
--tagis present, we shouldn't be reading in the porter.yaml in the current directory at all. So don't do a build before install, but it should also apply to how we default the instance name, etc. The fix is to not read in the porter.yaml in the current directory which is what was triggering the bad behavior.If we do merge this, we should keep it as canary for a while and use it to ensure that other scenarios weren't inadvertently relying on some other side-effect of having the manifest loaded. I wouldn't recommend immediately turning this around and releasing it.
Fixes #585