Add scaffolding for new porter archive command #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the scaffolding for the new Porter archive command. It's currently hidden, but I wanted to open a PR that introduced it so we could figure out if these options/command experience are correct.
vdice
approved these changes
Sep 17, 2019
carolynvs
requested changes
Sep 17, 2019
pkg/porter/archive.go
Outdated
| // any referenced images locally (if needed), export them to individual layers, generate a bundle.json and | ||
| // then generate a gzipped tar archive containing the bundle.json and the images | ||
| func (p *Porter) Archive(opts ArchiveOptions) error { | ||
| return nil |
There was a problem hiding this comment.
Would you return an error saying "not implemented yet" just so that someone playing with canary doesn't wonder?
There was a problem hiding this comment.
Yep! I set the cmds themselves to Hidden: true but I think this is also a good idea. Happy to write up some contributing guidelines related to breaking up PRs / cmd reviews if you'd like after this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the scaffolding for the new Porter archive command. It's currently hidden, but I wanted to open a PR that introduced it so we could figure out if these options/command experience are correct.