Add in delete mixin command

[bradcypert]

What does this change

This PR adds in the ability to delete a mixin by using the porter mixin delete NAME command, where NAME is a mixin name like "helm".

➜ porter mixin delete
Error: no mixin name was specified

➜ porter mixin delete helm
Error: Could not find helm in the mixin directory.

➜ porter mixin install helm
installed helm mixin
helm v0.8.0-beta.1 (8325d71) by DeisLabs

➜ porter mixin delete helm
Deleted helm mixin

What issue does it fix

Closes #613

Notes for the reviewer

This is my first PR and I tried to follow as many existing patterns and practices as I could, but if something seems off, just let me know and I'll try to update it :)

Checklist

• Unit Tests
• Documentation
  • Documentation Not Impacted

[msftclas]

All CLA requirements met.

[bradcypert]

@carolynvs if you have a moment, can you checkout this branch and see if builds work locally for you? I haven't done anything with dep before, and I'm not 100% sure it's setup properly. I'm getting errors when trying to build, but it looks like CI is fine?

➜ make build
go generate ./...
/Library/Developer/CommandLineTools/usr/bin/make --no-print-directory build MIXIN=porter -f mixin.mk BINDIR=bin
mkdir -p bin
go build -ldflags '-w -X github.com/deislabs/porter/pkg.Version=v0.16.1-beta.1-2-gcee6ef7 -X github.com/deislabs/porter/pkg.Commit=cee6ef7' -o bin/porter ./cmd/porter
# github.com/dieslabs/porter/cmd/porter
cmd/porter/mixins.go:77:10: undefined: mixin.DeleteOptions
cmd/porter/mixins.go:86:12: p.DeleteMixin undefined (type *porter.Porter has no field or method DeleteMixin)
make[1]: *** [build-client] Error 2
make: *** [build-porter] Error 2

[carolynvs]

Oh! Not all of the CI runs for new contributors until we have reviewed and said it's safe to run. I'll make sure to mention that in the contributing guide.

Here let me kick it off for you quick so you can see the full CI run in azure pipelines.

[carolynvs]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[bradcypert]

@carolynvs disregard. I found my mistake. dieslabs => deislabs.

[carolynvs]

I just left a comment on why I think the build is failing for you. Try moving that struct and hopefully it should pass (or at least move on to new and more interesting errors!). 🤞

[carolynvs]

Oh boy, I will never be good at helping people find spelling mistakes! 😂

[carolynvs]

This is looking great! Just a few small changes need to be made to get it ready to merge.

[carolynvs]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[bradcypert]

@carolynvs I made some changes around the areas that you mentioned above. If anything else looks off, please don't hesitate to lemme know. I'm just thrilled to have the opportunity to learn from a large go project :)

[carolynvs]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[carolynvs]

I'm going to fix our CI so that the bulk of it runs automatically for external contributors. Thanks for you patience with us having to run them manually for the next few days! 😊

[carolynvs]

It helps to not include unrelated changes in a pull request. Fixing a single bad link is fine to sneak in though, and it sounds like from your commit message that was the intent. Let's revert the changes to this file other than the missing ) and this should be ready to merge. 🚀

[bradcypert]

Sorry about that! I wanted to fix the missing ) and I think my markdown plugin ran a format-on-save. I should have checked the diff before committing it! I'll get this fixed.

[carolynvs]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[carolynvs]

This looks great, thank you! 👍