Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publish.go): print initiation status to console for publishing from an archive #746

Merged
merged 1 commit into from Oct 17, 2019

Conversation

vdice
Copy link
Member

@vdice vdice commented Oct 17, 2019

What does this change

As the process of pushing new images for a bundle may take some time prior to the standard output from the PushBundle(...) call later on, I wanted to add a simple status message and not just have the command sit there blank, potentially for quite a bit. Idea shamelessly copied from #745

What issue does it fix

N/A

Notes for the reviewer

N/A

Checklist

  • Unit Tests
  • Documentation
    • Documentation Not Impacted

@vdice vdice force-pushed the feat/publish-archive-status-msg branch from d152ba5 to c68c03a Compare October 17, 2019 20:23
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vdice vdice merged commit 5154ad2 into getporter:master Oct 17, 2019
@vdice vdice deleted the feat/publish-archive-status-msg branch October 17, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants