Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(generate.go): update the mixin regex to support hyphens #971

Merged
merged 1 commit into from
Apr 2, 2020
Merged

feat(generate.go): update the mixin regex to support hyphens #971

merged 1 commit into from
Apr 2, 2020

Conversation

vdice
Copy link
Member

@vdice vdice commented Apr 2, 2020

What does this change

  • Updates the mixin regex that the feed generate logic uses to allow for hyphens

Say, for a forthcoming docker-compose mixin!

What issue does it fix

N/A

Notes for the reviewer

N/A

Checklist

  • Unit Tests
  • Documentation
    • Documentation Not Impacted

@vdice
feat(generate.go): update the mixin regex to support hyphens
4daf2a3 
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
@vdice vdice requested a review from carolynvs April 2, 2020 20:06
carolynvs
carolynvs approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it while GH is up

@vdice vdice merged commit 3e565fc into getporter:master Apr 2, 2020
@vdice vdice deleted the feat/gen-support-hyphens branch April 2, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolynvs carolynvs carolynvs approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vdice @carolynvs