Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(schema.json): update required extension section of porter manifest schema #979

Merged
merged 1 commit into from
Apr 10, 2020
Merged

feat(schema.json): update required extension section of porter manifest schema #979

merged 1 commit into from
Apr 10, 2020

Conversation

vdice
Copy link
Member

@vdice vdice commented Apr 10, 2020

What does this change

Follow-up to #977 per #977 (comment)

What issue does it fix

N/A

Notes for the reviewer

N/A

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

@vdice
feat(schema.json): update required extension section of porter manife…
609d2c7 
…st schema

Signed-off-by: Vaughn Dice <vadice@microsoft.com>
@vdice vdice requested a review from carolynvs April 10, 2020 18:34
carolynvs
carolynvs approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated in VS Code with the 0.2.0 version of the extension :shipit:

@vdice vdice merged commit b15c410 into getporter:master Apr 10, 2020
@vdice vdice deleted the feat/porter-schema-update branch April 10, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolynvs carolynvs carolynvs approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vdice @carolynvs