Set azure user agent env for azure provider #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinozzZ
force-pushed
the
user-agent
branch
4 times, most recently
from
5dd7dda
to
1a370a5
Compare
Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
carolynvs
reviewed
Jan 12, 2023
| @@ -51,6 +51,28 @@ Then use `initFile` to specify the relative path to this file within workingDir. | |||
| This will dramatically improve Docker image layer caching and performance when building, publishing and installing the bundle. | |||
| > Note: this approach isn't suitable when using terraform modules as those need to be "initilized" as well but aren't specified in the `initFile`. You shouldn't specifiy an `initFile` in this situation. | |||
|
|
|||
| ### User Agent Opt Out | |||
|
|
|||
| When you declare the mixin, you can disable the mixin from customizing the azure user agent string | |||
There was a problem hiding this comment.
We should add in a follow-up PR more language that encourages people to identify how to support user agents for other providers, like aws. The aws mixin uses a user agent string too, and there may be more providers as well that would find this useful.
pkg/terraform/build_test.go
Outdated
| expectedUserAgent string | ||
| }{ | ||
| {name: "build with custom config", inputFile: "testdata/build-input-with-config.yaml", expectedVersion: "https://releases.hashicorp.com/terraform/0.13.0-rc1/terraform_0.13.0-rc1_linux_amd64.zip", expectedUserAgent: "ENV PORTER_TERRAFORM_MIXIN_USER_AGENT_OPT_OUT=\"true\"\nENV AZURE_HTTP_USER_AGENT=\"\""}, | ||
| {name: "build with the default Terraform config", expectedVersion: "https://releases.hashicorp.com/terraform/1.2.9/terraform_1.2.9_linux_amd64.zip", expectedUserAgent: "ENV PORTER_TERRAFORM_MIXIN_USER_AGENT_OPT_OUT=\"false\"\nENV AZURE_HTTP_USER_AGENT=\""}, |
There was a problem hiding this comment.
Shouldn't the AZURE_HTTP_USER_AGENT environment variable be set in the dockerfile for this test case?
There was a problem hiding this comment.
Oops, just fixed it
Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
|
Oops I spoke too soon, the test is failing. 😊 |
Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
It's still the test data. It should be good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets Azure User Agent environment variable so that the azure terraform provider will be able to pick it up.
Users have options to opt out of it by setting the corresponding config.
related issue: #103