ci(*): add cli test #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
carolynvs
approved these changes
Jul 6, 2020
carolynvs
reviewed
Jul 6, 2020
| echo "Verifying instance output(s) via 'porter instance output show' after upgrade" | ||
| ${PORTER_HOME}/porter instance output show file_contents | grep -q "bar!" | ||
|
|
||
| cat ${PORTER_HOME}/claims/terraform.json |
There was a problem hiding this comment.
Heads up that this is going to break as soon as claims is redone. Once it's merged, we should switch to porter installation show terraform
There was a problem hiding this comment.
@carolynvs oh good call. Will the other instance commands break then as well? (Like porter instance output show above). Or will there be a deprecation period for instance commands once installation is introduced?
There was a problem hiding this comment.
I'll merge for now and we can tend to the cli tests once needed; or perhaps we'll be ready to convert to integration tests and api usage instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: publishing of the terraform bundle used in the cli test has been removed in this PR. I deemed this bundle trivial enough (only really useful for testing basic functionality) that we don't need to publish it any longer. (Note that all of the non-trivial examples in the main Porter repo are continually validated/published.) Thoughts?
Ref getporter/porter#1079 and getporter/porter#1118