upgrade finagle-mysql to 21.8.0 and separate scala 2.11 library dependencies #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krrrr38
changed the title
krrrr38
commented
Jul 13, 2021
build.sbt
Outdated
| if (scalaVersion.value.startsWith("2.11")) | ||
| "com.twitter" % "finagle-mysql_2.11" % "21.2.0" | ||
| else | ||
| "com.twitter" %% "finagle-mysql" % "21.6.0" |
There was a problem hiding this comment.
finagle drop scala 2.11 support after version 21.2.0
https://mvnrepository.com/artifact/com.twitter/finagle-mysql
For scala stewart, I use "com.twitter" % "finagle-mysql_2.11" explicitly not to upgrade.
|
Could you please review and merge this PR? 🙏 |
|
Could you please review and merge this PR? 🙏 @deusaquilus |
krrrr38
changed the title
|
@deusaquilus |
juliano
approved these changes
Oct 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2046
@getquill/maintainers @deusaquilus
btw I also want #1854 feature.